refactor: Improve type safety and error handling across multiple files, eslint fix

tests/rest/spotifyTokenGenerator.test.ts

@@ -41,6 +41,7 @@ describe("SpotifyTokenGenerator", () => {
         it("should handle token service errors", async () => {
             mockTokenService.refreshToken.mockRejectedValue(new Error("Spotify API error"));
             const response = await request(app).post("/spotify/token/refresh").send(validRefreshData).expect(500);
+            console.log(response.body)
             expect(response.body.data.message).toBe("Failed to handle spotify token request");
         });
 

tests/server.test.ts

@@ -1,7 +1,7 @@
 import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
 import request from "supertest";
 import { Server } from "../src/server";
-import { Router, type Request, type Response, type NextFunction } from "express"; // Import Express types
+import { Router, type Request, type Response, type NextFunction } from "express";
 import type { Express } from "express";
 import { authLimiter } from "../src/rest/middleware/rateLimit";
 

tests/services/s3Service.test.ts

@@ -79,8 +79,9 @@ describe("S3Service", () => {
         });
 
         it("should call ensureBucketExists and handle existing buckets gracefully", async () => {
-            mockSend.mockRejectedValue({ name: "BucketAlreadyOwnedByYou" });
-
+            const bucketError = new Error();
+            bucketError.name = "BucketAlreadyOwnedByYou";
+            mockSend.mockRejectedValue(bucketError);
             await expect(s3Service.ensureBucketExists()).resolves.toBeUndefined();
 
             expect(mockSend).toHaveBeenCalledWith(expect.any(CreateBucketCommand));

tests/services/spotifyPollingService.test.ts

@@ -6,7 +6,6 @@ import { SpotifyTokenService } from "../../src/services/spotifyTokenService";
 import { appEventBus, SPOTIFY_STATE_UPDATED_EVENT } from "../../src/utils/eventBus";
 import { SpotifyPollingService } from "../../src/services/spotifyPollingService";
 import { IUser } from "../../src/db/models/user";
-// @ts-ignore
 import { createMockSpotifyApiService, createMockSpotifyTokenService, createMockUserService } from "../helpers/testSetup";
 
 vi.mock("../../src/services/db/UserService");